-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/CLN: Allow the BlockManager to have a non-unique items (axis 0) #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG: fix construction of a DataFrame with duplicative indices
…get) when using a non-unique index (GH2786 for the warning and GH3230 for applymap) TST: test for GH2194 (which is fixed)
… of dealing with columns duplicate or not
Ha, the rabbit hole, you went down it. Thanks for sparing me this one! |
good one, jeff. I think that's the most issues addressed by a single PR ever. :) |
I would say that's not a good thing, but they r all related :) |
@jreback you have an iron stomach :) |
…on the decoration useful when specifiying an index that is **known** to be unique (e.g. in the case of a default range index)
jreback
added a commit
that referenced
this pull request
May 2, 2013
BUG/CLN: Allow the BlockManager to have a non-unique items (axis 0)
This was referenced May 2, 2013
This was referenced May 3, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows iget support to always find the index (even across dtypes) error msg when trying to split duplicated columns across dtypes #2194
(removed warning) df.applymap duplicates data with frame has dupe columns #2786, and fix Enable applymap for dataframes with duplicate columns #3230
this value (useful in order to avoid a computation you know to be true, e.g. is_unique = True
for a default index
partially fixes #3468
This would previously raise (same dtype assignment to a non-multi dtype frame with dup indicies)
construction of a multi-dtype frame with a dup index (#2194) is fixed
This was also previously would raise
For those of you interested.....here is the new ref_loc indexer for duplicate columns
its by necessity a block oriented indexer, returns the column map (by column number) to a tuple of the block and the index in the block, only created when needed (e.g. when trying to get a column via iget and the index is non-unique, and the results are cached), this is #3092
Fixed the #2786, #3230 bug that caused applymap to not work (we temp worked around by raising a ValueError; removed that check)
Finally, to_csv writing has been fixed to use a single column mapper (which is derived from the ref_locs if the index is non-unique or the column numbering if it is unique)