Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Unbound Variable edge access when BinGrouper is empty #3510

Closed
wants to merge 1 commit into from
Closed

Fixed Unbound Variable edge access when BinGrouper is empty #3510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ pandas 0.11.1
- Duplicate indexes with getitem will return items in the correct order (GH3455_, GH3457_)
- Fix sorting in a frame with a list of columns which contains datetime64[ns] dtypes (GH3461_)
- DataFrames fetched via FRED now handle '.' as a NaN. (GH3469_)
- Fixed bug in groupby with empty series referencing a variable before assignment. (GH3510_)

.. _GH3164: https://github.com/pydata/pandas/issues/3164
.. _GH3251: https://github.com/pydata/pandas/issues/3251
Expand All @@ -73,6 +74,7 @@ pandas 0.11.1
.. _GH3461: https://github.com/pydata/pandas/issues/3461
.. _GH3448: https://github.com/pydata/pandas/issues/3448
.. _GH3449: https://github.com/pydata/pandas/issues/3449
.. _GH3510: https://github.com/pydata/pandas/issues/3510


pandas 0.11.0
Expand Down
8 changes: 4 additions & 4 deletions pandas/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,8 +1012,8 @@ def get_iterator(self, data, axis=0):
yield label, data[start:edge]
start = edge

if edge < len(data):
yield self.binlabels[-1], data[edge:]
if start < len(data):
yield self.binlabels[-1], data[start:]
else:
start = 0
for edge, label in izip(self.bins, self.binlabels):
Expand All @@ -1022,8 +1022,8 @@ def get_iterator(self, data, axis=0):
start = edge

n = len(data.axes[axis])
if edge < n:
inds = range(edge, n)
if start < n:
inds = range(start, n)
yield self.binlabels[-1], data.take(inds, axis=axis)

def apply(self, f, data, axis=0, keep_internal=False):
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2427,6 +2427,16 @@ def noddy(value, weight):
# don't die
no_toes = df_grouped.apply(lambda x: noddy(x.value, x.weight ))

def test_groupby_with_empty(self):
import pandas as pd
index = pd.DatetimeIndex(())
data = ()
series = pd.Series(data, index)
grouper = pd.tseries.resample.TimeGrouper('D')
grouped = series.groupby(grouper)
assert next(iter(grouped), None) is None


def assert_fp_equal(a, b):
assert((np.abs(a - b) < 1e-12).all())

Expand Down