Fixed apply_index #35165
Merged
Fixed apply_index #35165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Frequency
jbrockmendel
reviewed
Jul 7, 2020
jbrockmendel
reviewed
Jul 7, 2020
jbrockmendel
reviewed
Jul 7, 2020
|
CI is passing, travis just hasn't reported back. |
|
cc @jreback |
jreback
reviewed
Jul 14, 2020
| @@ -938,6 +945,7 @@ Methods | |||
| :toctree: api/ | |||
|
|
|||
| FY5253.apply | |||
| FY5253.apply_index | |||
There was a problem hiding this comment.
do we need to add these back if we are deprecating?
There was a problem hiding this comment.
I don't know why, but sphinx started complaining about these not being present. Which is technically correct, since it's a method on those classes. It just raises.
So I think keep for now, and just remove them all when we enforce the deprecation in 2.0
|
All green again. |
|
thanks @TomAugspurger |
fangchenli
pushed a commit
to fangchenli/pandas
that referenced
this pull request
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34580