-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: HDFStore enhancements #3531
Conversation
this is technically an API change, so anyone have an issue with it? or should I allow it, and maybe do a warning? as this is technically ok, but I think with an HDFStore it is just wrong.... @wesm ?
|
…on (GH3499_) TST: added legacy_table_0.11 table and tests
DOC: update release notes/whatsnew, added whatsnew 0.11.1 to index.rst ENH: warn a FrequencyWarning if appending with a different frequency that existing
I changed to a warning (see description) if attempting to append with a different frequency than what exists in the store (so it allows you to catch the warning if you really want to do this) appending a timezone that is different will raise, however |
This is great, but I think there is a problem with the tz storage. If you run the test with tz set in date_range, the resulting date_range retrieved from the store is shifted 5 hours. df = DataFrame(dict(A = Series(xrange(3), index=date_range('2000-1-1',periods=3,freq='H', tz='US/Eastern')))) will fail the equal test. |
works in master (this is not released yet btw), its in 0.12 what version are you trying on?
|
never mind it is NOT workg...thought my test was catching it...thanks! |
see #4098; this was tested as a column (and not an index), I'll see if I can fix this |
Seems to me like the table mode breaks which I think is consistent with what you're saying (not clear to me in the first example without table mode if the DatetimeIndex is being stored as such rather than a column). Also, I'm curious to see if 'select' will be impacted at all by this change. |
@rockg thanks for the report...fixed in master |
will warn if the existing frequency of an index is different than an appended one
(thought raising was too strict)