DEPR: Deprecate inplace param in MultiIndex.set_codes and MultiIndex.set_levels #35626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
jreback
requested changes
Aug 8, 2020
doc/source/user_guide/indexing.rst
Outdated
| to set these attributes directly. They default to returning a copy; however, | ||
| you can specify ``inplace=True`` to have the data change in place. | ||
| ``name`` attribute. You can use the ``rename``, ``set_names`` to set these attributes | ||
| directly. They default to returning a copy; however, you can specify ``inplace=True`` to |
There was a problem hiding this comment.
you can remove the inplace ref
|
Updated. |
topper-123
force-pushed
the
deprecate_MultiIndex_inplace
branch
from
eb5cf1a
to
71c1be9
Compare
jreback
reviewed
Aug 10, 2020
| @@ -898,7 +909,7 @@ def _set_codes( | |||
| self._tuples = None | |||
| self._reset_cache() | |||
|
|
|||
| def set_codes(self, codes, level=None, inplace=False, verify_integrity=True): | |||
| def set_codes(self, codes, level=None, inplace=None, verify_integrity=True): | |||
There was a problem hiding this comment.
typing these would be good at some point
jreback
approved these changes
Aug 10, 2020
|
thanks @topper-123 |
maxwell-k
added a commit
to maxwell-k/qgridtrusted
that referenced
this pull request
Jan 12, 2024
This argument was deprecated in Pandas 1.2 and removed in 2.0 https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.MultiIndex.set_levels.html pandas-dev/pandas#35626
maxwell-k
added a commit
to maxwell-k/qgridtrusted
that referenced
this pull request
Jan 12, 2024
This argument was deprecated in Pandas 1.2 and removed in 2.0 https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.MultiIndex.set_levels.html pandas-dev/pandas#35626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
inplaceparameter inMultiIndex.set_codesandMultiIndex.set_levels.Allowing inplace ops in indexes makes them more complicated wtr. caching etc. After
inplaceis removed,MultiIndexwill be immutable, except thenamesattribute, similarly to other index classes.