DEPR: Index.__and__, __or__, __xor__ behaving as set ops #37374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 24, 2020
done
we dont support inplace ops for these |
jreback
requested changes
Oct 26, 2020
| @@ -725,7 +725,7 @@ def __array_ufunc__( | |||
| # it to handle *args. | |||
| index = alignable[0].index | |||
| for s in alignable[1:]: | |||
| index |= s.index | |||
There was a problem hiding this comment.
we certainly are using this (or at least were), so need to make sure these inplace ops are deprecated as well.
There was a problem hiding this comment.
can you add some tests for the inplace to make sure they are warning as well
jreback
approved these changes
Oct 31, 2020
|
lgtm merge on greenish |
…o depr-index-defer
|
thanks @jbrockmendel |
|
hmm this may have broken some tests: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=46712&view=logs&j=eab14f69-13b6-5db7-daeb-7b778629410b&t=ce687173-08c6-5301-838d-71b2dda24510 this is a just rebased pr |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
just opened #37587 for this |
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
3 tasks
1 task
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref #30228