Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: use default_axes=True where multiple plots #37734

Merged
merged 1 commit into from
Nov 10, 2020
Merged

TST: use default_axes=True where multiple plots #37734

merged 1 commit into from
Nov 10, 2020

Conversation

ivanovmg
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Use new kwarg default_axes in _check_plot_works (#37274), which allows one to eliminate catching warnings related to multiple subplots created.
There warnings are not related to the plotting function, but rather were caused by the _check_plot_works itself.

charlesdong1991
charlesdong1991 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@charlesdong1991 charlesdong1991 added Clean Testing pandas testing functions or related to the test suite Visualization plotting labels Nov 10, 2020
@charlesdong1991 charlesdong1991 added this to the 1.2 milestone Nov 10, 2020
@WillAyd WillAyd merged commit daf999f into pandas-dev:master Nov 10, 2020
@WillAyd
Copy link
Member

WillAyd commented Nov 10, 2020

Thanks @ivanovmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovmg @WillAyd @charlesdong1991