Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: trim error traceback in allows_duplicate_labels whatsnew entry #38184

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 30, 2020

xref #37784 (comment)

Ensure a more readable section (shorter error traceback) by using a plain code-block instead of the dynamic ipython directive

@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Nov 30, 2020

pd.Series([1, 2], index=['a', 'a'])
In [1]: pd.Series([1, 2], index=['a', 'a'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically you don't need to change the block on data creation, but nbd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By keeping it in a single directive, it gives a consistent code block (not 2 different code blocks with different look or inconsistent number), so in this case nicer I think.

@jreback jreback merged commit 3902585 into pandas-dev:master Nov 30, 2020
@jorisvandenbossche jorisvandenbossche deleted the doc-whatsnew12-error-traceback branch November 30, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants