CLN: use .view(i8) instead of .astype(i8) for datetimelike values #38535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mroeschke
reviewed
Dec 17, 2020
| @@ -252,7 +253,9 @@ def __init__( | |||
| raise ValueError( | |||
| "halflife must be a string or datetime.timedelta object" | |||
| ) | |||
| self.times = np.asarray(times.astype(np.int64)) | |||
| if isna(times).any(): | |||
| raise ValueError("Cannot convert NaT values to integer") | |||
There was a problem hiding this comment.
Could you add a test for this case?
There was a problem hiding this comment.
double-checked and you're right we dont have any. suggestions for what this might look like?
There was a problem hiding this comment.
Something simple like
with pytest.raises(ValueError, match=...):
Series(range(1)).ewm(com=0.1, times=to_datetime(['NaT'])))
works.
|
any perf benefits? |
maybe some call overhead, but the existing astype call is already doing view under the hood (which is not great) |
mroeschke
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prelude to deprecating the astype behavior