Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: disallow scalar in CategoricalIndex construtor #38614

Merged
merged 4 commits into from
Dec 23, 2020
Merged

BUG: disallow scalar in CategoricalIndex construtor #38614

merged 4 commits into from
Dec 23, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 21, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback mentioned this pull request Dec 22, 2020
Merged
5 tasks
@jreback jreback added the Categorical Categorical Data Type label Dec 22, 2020
@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

i guess need to deprecate here as well (unless you use the Categorical for constrution)

@jbrockmendel
Copy link
Member Author

i guess need to deprecate here as well

i think this is pretty unambiguously a bug

@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

i guess need to deprecate here as well

i think this is pretty unambiguously a bug

oh right yeah its a scalar in an Index, ok

@jreback jreback added this to the 1.3 milestone Dec 22, 2020
@jreback
Copy link
Contributor

jreback commented Dec 22, 2020

ok i guess add a whatsnew here to document

@jbrockmendel
Copy link
Member Author

whatsnew added + greenish

@jreback jreback merged commit 019d053 into pandas-dev:master Dec 23, 2020
@jbrockmendel jbrockmendel deleted the bug-ci-scalar branch December 23, 2020 16:01
jorisvandenbossche
jorisvandenbossche reviewed Jan 4, 2021
View reviewed changes
pandas/core/indexes/category.py
# if data is None, then categories must be provided
if data is not None or categories is None:
raise cls._scalar_data_error(data)
data = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not actually about passing scalar data, but about passing no data (eg pd.CategoricalIndex(categories=['a', 'b'])). We generally support constructors with passing no data to create an empty (eg Series also allows this).

So I would either keep supporting this, or either it should at least be deprecated (this eg breaks dask)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #38944 to track this

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 4, 2021
Closed
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
BUG: disallow scalar in CategoricalIndex construtor (pandas-dev#38614)
be4dbf8
@simonjayhawkins simonjayhawkins mentioned this pull request May 22, 2021
Merged
4 tasks
@ggold7046 ggold7046 mentioned this pull request Aug 10, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

Assignees
No one assigned
Labels
Categorical Categorical Data Type
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche