Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: MultiIndex, IntervalIndex intersection with Categorical #38653

Merged
merged 6 commits into from
Dec 23, 2020
Merged

BUG: MultiIndex, IntervalIndex intersection with Categorical #38653

merged 6 commits into from
Dec 23, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 23, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Categorical Categorical Data Type MultiIndex labels Dec 23, 2020
@jreback jreback added this to the 1.3 milestone Dec 23, 2020
@jreback
Copy link
Contributor

jreback commented Dec 23, 2020

what is the bug here? need a whatsnew? can you rebase

@jbrockmendel
Copy link
Member Author

can you rebase

just did, and managed to fully share the intersection methods!

need a whatsnew?

added

what is the bug here?

mi = pd.MultiIndex.from_product([range(2), range(3)])
cat = mi.to_flat_index().astype('category')

>>> mi.intersection(cat)
MultiIndex([], )

@jreback
Copy link
Contributor

jreback commented Dec 23, 2020

nice ping on greenish

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit a943a09 into pandas-dev:master Dec 23, 2020
@jbrockmendel jbrockmendel deleted the bug-intersect-categorical branch December 23, 2020 20:16
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
BUG: MultiIndex, IntervalIndex intersection with Categorical (pandas-…
05dca24 
…dev#38653)
@ggold7046 ggold7046 mentioned this pull request Aug 10, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type MultiIndex
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback