-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PULL_REQUEST_TEMPLATE.md #38696
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BobinMathew !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BobinMathew - sorry to go back on this, but there's been some discussion in #38694 and it's been suggested to instead link to the docs and just have "Ensure all linting tests pass, see here how to run them" here
Do you want to update this in the template and also in the docs? Feel free to ask if you want/need help with any of this
I would love to contribute 😁 |
did you mean insert ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BobinMathew for updating! 👍 Just have some requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BobinMathew , we're almost there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BobinMathew !
@jorisvandenbossche any comments?
@MarcoGorelli |
DOC: update contributing.rstLocation of the documentationdoc/source/development/contributing.rst Documentation problemNeed additional information about the command that verifies the linting of code files. Suggested fix for documentation
The command verifies the linting of code files, it looks for common mistake patterns ☝ Is this issue description appropriate for the new issue? |
take |
thanks @BobinMathew |
Thankyou @MarcoGorelli and others for the support 🤝 |
pre-commit run --from-ref=upstream/master --to-ref=HEAD --all-files