FIX: change initObjToJSON return type #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because clang complains about the return type. There's a call to the macro import_array() which injects a return statement into wherever it's used.
|
also cc @Komnomnomnom what do u think? |
|
Sounds good to me, as a fix in ultrajson I think it should be pushed upstream to them as well though. Which I can do once I've merged in their recent changes, as I might have more stuff for them. |
jreback
added a commit
that referenced
this pull request
Jun 15, 2013
FIX: change initObjToJSON return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because clang complains about the return type. There's a
call to the macro import_array() which injects a return statement into
wherever it's used.
closes #3872.