-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: read_excel does not work for most file handles #38819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Changes look good to me, and they open up a minor simplification of inspect_excel_format. That simplification should be done in a followup for 1.3, I've opened #38823 to track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ping on green.
slightly OT, you should use named branches rather than using your own master for the branches (then you can have multiple changes in progress if needbe)
@jreback green |
thanks @twoertwein very nice |
@meeseeksdev backport 1.2.x |
…les (#38832) Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
@@ -20,6 +20,7 @@ Fixed regressions | |||
- Bug in repr of float-like strings of an ``object`` dtype having trailing 0's truncated after the decimal (:issue:`38708`) | |||
- Fixed regression in :meth:`DataFrame.groupby()` with :class:`Categorical` grouping column not showing unused categories for ``grouped.indices`` (:issue:`38642`) | |||
- Fixed regression in :meth:`DataFrame.any` and :meth:`DataFrame.all` not returning a result for tz-aware ``datetime64`` columns (:issue:`38723`) | |||
- :func:`read_excel` does not work for non-rawbyte file handles (issue:`38788`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect maybe a copy and paste error, should have been :issue:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in #38850
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Co-authored-by: Jeff Reback <jeff@reback.net>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff