Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGR: read_excel does not work for most file handles #38819

Merged
merged 2 commits into from
Dec 30, 2020
Merged

REGR: read_excel does not work for most file handles #38819

merged 2 commits into from
Dec 30, 2020

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Dec 30, 2020

@simonjayhawkins simonjayhawkins added this to the 1.2.1 milestone Dec 30, 2020
@simonjayhawkins simonjayhawkins added the IO Excel read_excel, to_excel label Dec 30, 2020
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Changes look good to me, and they open up a minor simplification of inspect_excel_format. That simplification should be done in a followup for 1.3, I've opened #38823 to track.

@rhshadrach rhshadrach added the Regression Functionality that used to work in a prior pandas version label Dec 30, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ping on green.

slightly OT, you should use named branches rather than using your own master for the branches (then you can have multiple changes in progress if needbe)

@twoertwein
Copy link
Member Author

@jreback green

@jreback jreback merged commit 8232658 into pandas-dev:master Dec 30, 2020
@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

thanks @twoertwein very nice

@jreback
Copy link
Contributor

jreback commented Dec 30, 2020

@meeseeksdev backport 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 30, 2020
jreback pushed a commit that referenced this pull request Dec 30, 2020
…les (#38832)

Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
@@ -20,6 +20,7 @@ Fixed regressions
- Bug in repr of float-like strings of an ``object`` dtype having trailing 0's truncated after the decimal (:issue:`38708`)
- Fixed regression in :meth:`DataFrame.groupby()` with :class:`Categorical` grouping column not showing unused categories for ``grouped.indices`` (:issue:`38642`)
- Fixed regression in :meth:`DataFrame.any` and :meth:`DataFrame.all` not returning a result for tz-aware ``datetime64`` columns (:issue:`38723`)
- :func:`read_excel` does not work for non-rawbyte file handles (issue:`38788`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect maybe a copy and paste error, should have been :issue:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #38850

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: read_excel throws FileNotFoundError with s3fs objects
4 participants