Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Close resources opened by pyxlsb #39134

Merged
merged 1 commit into from
Jan 13, 2021
Merged

BUG: Close resources opened by pyxlsb #39134

merged 1 commit into from
Jan 13, 2021

Conversation

twoertwein
Copy link
Member

Spin-off from #39047:

  • Close resources opened by pyxlsb
  • Use context manager when opening non-fsspec URLs (I'm not sure whether that reduced any ResourceWarnings but it can't hurt)

@jreback jreback added the IO Excel read_excel, to_excel label Jan 13, 2021
@jreback jreback added this to the 1.3 milestone Jan 13, 2021
@jreback jreback merged commit d616e3b into pandas-dev:master Jan 13, 2021
@jreback
Copy link
Contributor

jreback commented Jan 13, 2021

thanks @twoertwein

@twoertwein twoertwein deleted the resource_fixes branch January 13, 2021 15:20
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@twoertwein @luckyvs1
BUG: Close resources opened by pyxlsb (pandas-dev#39134)
08d83e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Excel read_excel, to_excel
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @jreback