DEPR: Styler.set_na_rep and .set_precision in favour of .format(na_rep='x', precision=3)
#40134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/io/formats/style.py
jreback
requested changes
Mar 3, 2021
jreback
requested changes
Mar 4, 2021
# Conflicts: # pandas/io/formats/style.py
jreback
requested changes
Mar 5, 2021
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
@jreback ping this is greenish, if you approve the changes to the docstring |
jreback
approved these changes
Mar 5, 2021
|
thanks @attack68 very nice! |
|
@attack68 want to make a PR enforcing this deprecation? |
|
yes will do. been waiting for the 2.0 tag to push to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
na_reparg overwrites existing when not given. #40032 and PR BUG/ENH:Styler.format()always inherits from.set_na_rep()#40060Styler.set_na_rep()andStyler.set_precision()in favour of, and incorporatingprecisionintoStyler.format(). Maintains some backwards compatibility with a deprecation warning, the copy mechanics remain broken.Styler.set_na_rep('MISS')is replaced and equivalent toStyler.format(na_rep='MISS')Styler.set_precision(5)is replaced and equivalent toStyler.format(precision=5)Styler.set_na_rep('MISS').set_precision(5)is equivalent toStyler.format(na_rep='MISS', precision=5)Styler.set_precision(5).set_na_rep('MISS')is equivalent toStyler.format(na_rep='MISS', precision=5)default_formatterandmaybe_wrap_formattermethods tomodulelevel.This PR was suggested after review of #40060 as an alternative. It seems to be a simpler and more consistent solution for API.