Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: tighten signature on maybe_convert_platform #40209

Merged
merged 1 commit into from
Mar 5, 2021
Merged

REF: tighten signature on maybe_convert_platform #40209

merged 1 commit into from
Mar 5, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Refactor Internal refactoring of code label Mar 4, 2021
@jreback jreback added this to the 1.3 milestone Mar 5, 2021
@jreback jreback merged commit fd0bd91 into pandas-dev:master Mar 5, 2021
jreback
jreback reviewed Mar 5, 2021
View reviewed changes
pandas/core/internals/construction.py
@@ -400,7 +400,15 @@ def _prep_ndarray(values, copy: bool = True) -> np.ndarray:
return arr[..., np.newaxis]

def convert(v):
return maybe_convert_platform(v)
if not is_list_like(v) or isinstance(v, ABCDataFrame):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a pretty general function (just commenting nothing to do now)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah im hoping we'll end up with just one sanitize_array-like function by the end of this process. the hard part at this point is deciding what we want to do about #40114, #40110, and #24435

@jbrockmendel jbrockmendel deleted the ref-maybe_convert_platform branch March 5, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback