Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: remove DatetimeBlock, TimeDeltaBlock #40614

Merged
merged 21 commits into from
Apr 2, 2021

Conversation

jbrockmendel
Copy link
Member

sits on top of #40456

@jbrockmendel jbrockmendel added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Mar 28, 2021
@jreback jreback added this to the 1.3 milestone Apr 2, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jreback jreback merged commit 4554635 into pandas-dev:master Apr 2, 2021
@jbrockmendel jbrockmendel deleted the ref-hybrid-5 branch April 2, 2021 16:13
@jorisvandenbossche
Copy link
Member

Similarly as #40527, we should maybe first deprecate those Block classes before removing them?

@jreback
Copy link
Contributor

jreback commented Apr 2, 2021

why? what is using them

vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jorisvandenbossche
Copy link
Member

In pyarrow, we are explicitly using CategoricalBlock, DatetimeTZBlock, ObjectBlock and ExtensionBlock. So not DatetimeBlock or TimedeltaBlock, but that's only one data point, and given that we are already using many of the block classes, I think we should be careful with removing any of them.

@jbrockmendel
Copy link
Member Author

These are things that downstream libraries shouldnt be using. If this breaks something for someone we can deprecate like we did for CategoricalBlock, but I don't see any reason to do so pre-emptively, given that no one chimed in in #40226 saying they use these.

@jreback
Copy link
Contributor

jreback commented Apr 6, 2021

i agree with @jbrockmendel
perpetuating internals is not great

if something downstream is breaking that we can re add and depreciate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants