BUG: RollingGroupby MultiIndex levels dropped #40701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm should we target 1.2.4? e.g. how does this compare to that behavior (and how does that compare to 1.1.x)? |
|
It looks like you mentioned before this would be okay for 1.3 and we reverted this before for 1.2.x This gets us back to 1.1.3 behavior which was correct according to this bug report #38523 |
ok awesome |
jreback
reviewed
Apr 2, 2021
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -693,6 +693,7 @@ Groupby/resample/rolling | |||
| - Bug in :class:`core.window.ewm.ExponentialMovingWindow` when calling ``__getitem__`` would not retain ``com``, ``span``, ``alpha`` or ``halflife`` attributes (:issue:`40164`) | |||
| - :class:`core.window.ewm.ExponentialMovingWindow` now raises a ``NotImplementedError`` when specifying ``times`` with ``adjust=False`` due to an incorrect calculation (:issue:`40098`) | |||
| - Bug in :meth:`Series.asfreq` and :meth:`DataFrame.asfreq` dropping rows when the index is not sorted (:issue:`39805`) | |||
| - Bug in :class:`core.window.rolling.RollingGroupby` where an level of a :class:`MultiIndex` would be dropped if it overlapped with a groupby label (:issue:`38787`, :issue:`38523`) | |||
There was a problem hiding this comment.
let's make this a full sub-section and mention this goes back to 1.1.x behavior
|
thanks @mroeschke |
Closed
2 tasks
3 tasks
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially #38737 but targeted for 1.3 as it appears that the current behavior is largely unexpected