Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate joining over a different number of levels #40993

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 17, 2021

I think deprecating this is a good idea, I stumbled across this accidentally this week and found this really odd

@phofl phofl added Deprecate Functionality to remove in pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Apr 17, 2021
"merging between different levels can give an unintended "
f"result ({left.columns.nlevels} levels on the left,"
"merging between different levels is deprecated and will be removed "
f"in a futere version. ({left.columns.nlevels} levels on the left,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

futere -> future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mroeschke mroeschke added this to the 1.3 milestone Apr 20, 2021
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

@jreback
Copy link
Contributor

jreback commented Apr 20, 2021

lgtm ping when updated

@jreback jreback merged commit a77be85 into pandas-dev:master Apr 20, 2021
@jreback
Copy link
Contributor

jreback commented Apr 20, 2021

thanks @phofl

yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
@phofl phofl deleted the 34862 branch April 21, 2021 20:40
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: Merging on different number of levels
3 participants