REF: Back DatetimeTZBlock with sometimes-2D DTA #41082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Apr 22, 2021
|
|
||
|
|
||
| # --------------------------------------------------------------------- | ||
|
|
||
|
|
||
| def _prep_ndarray(values, copy: bool = True) -> np.ndarray: | ||
| if isinstance(values, TimedeltaArray): | ||
| # On older numpy, np.asarray below apparently does not call __array__, |
There was a problem hiding this comment.
this still true? (e.g. we are now min 1.17)
There was a problem hiding this comment.
nice, ill take a look
jreback
added
Internals
|
just a question for followup |
jbrockmendel
added a commit
that referenced
this pull request
Apr 23, 2021
This reverts commit 6b6d8fd.
This was referenced Apr 23, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #40149 but with the perf-improving edits to frame.py reverted