BUG: groupby sum, mean, var should always be floats #41139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an_median_float � Conflicts: � pandas/core/dtypes/cast.py
rhshadrach
added
Bug
Dtype Conversions
5 tasks
rhshadrach
force-pushed
the
mean_median_float
branch
from
8c16be3
to
eb57258
Compare
jreback
requested changes
Apr 26, 2021
…an_median_float � Conflicts: � doc/source/whatsnew/v1.3.0.rst � pandas/core/groupby/generic.py � pandas/core/groupby/groupby.py � pandas/tests/groupby/test_groupby.py
|
looks good. can you add a whatsnew note. might consider a sub-section as this is a 'bigger' bug fix but either way. |
|
@jreback Thanks - whatsnew section added. |
…an_median_float
jreback
approved these changes
May 21, 2021
|
thanks @rhshadrach |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
jbrockmendel
reviewed
Nov 9, 2021
| @@ -1687,7 +1687,7 @@ def f(data, add_arg): | |||
|
|
|||
| # Testing dataframe | |||
| df = DataFrame({"A": 1, "B": 2}, index=date_range("2017", periods=10)) | |||
| result = df.groupby("A").resample("D").agg(f, multiplier) | |||
| result = df.groupby("A").resample("D").agg(f, multiplier).astype(float) | |||
| expected = df.groupby("A").resample("D").mean().multiply(multiplier) | |||
| # TODO: GH 41137 | |||
There was a problem hiding this comment.
@rhshadrach does this PR take care of the TODO comment here?
There was a problem hiding this comment.
Yes - thanks, I've opened #44374
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #40790