Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: DatetimeIndex.union with mixed timezones #41458

Merged
merged 2 commits into from
May 14, 2021
Merged

DEPR: DatetimeIndex.union with mixed timezones #41458

merged 2 commits into from
May 14, 2021

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses Timezones Timezone data dtype labels May 14, 2021
@jreback jreback added this to the 1.3 milestone May 14, 2021
@jreback jreback mentioned this pull request May 14, 2021
Closed
@jreback
Copy link
Contributor

jreback commented May 14, 2021

is this user facing anywhere aside from a direct index .union op? e.g. does this bubble to a concat?

@jbrockmendel
Copy link
Member Author

is this user facing anywhere aside from a direct index .union op? e.g. does this bubble to a concat?

not concat, might be used in merge, will look into this

@jbrockmendel
Copy link
Member Author

confirmed that merge is not affected (though we dont have any tests for this case with DTI, so ill add some in a separate PR)

@jreback jreback merged commit e0ca3de into pandas-dev:master May 14, 2021
@jreback
Copy link
Contributor

jreback commented May 14, 2021

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-dti-union branch May 14, 2021 16:26
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
DEPR: DatetimeIndex.union with mixed timezones (pandas-dev#41458)
c9d1671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Index Related to the Index class or subclasses Timezones Timezone data dtype
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

API: DatetimeIndex union vs join different behavior with mismatched tzs
2 participants
@jbrockmendel @jreback