Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate passing args as positional DataFrame/Series.ffill #41508

Merged
merged 12 commits into from
May 27, 2021
Merged

Deprecate passing args as positional DataFrame/Series.ffill #41508

merged 12 commits into from
May 27, 2021

Conversation

MarcoGorelli
Copy link
Member

@simonjayhawkins simonjayhawkins added the Deprecate Functionality to remove in pandas label May 17, 2021
@jorisvandenbossche jorisvandenbossche changed the title deprecate nonkeywordargs in ffill Deprecate passing args as positional DataFrame/Series.ffill May 17, 2021
@jorisvandenbossche jorisvandenbossche mentioned this pull request May 17, 2021
Closed
4 tasks
@MarcoGorelli MarcoGorelli marked this pull request as draft May 18, 2021 08:14
@MarcoGorelli MarcoGorelli marked this pull request as ready for review May 18, 2021 20:54
MarcoGorelli
MarcoGorelli commented May 19, 2021
View reviewed changes
pandas/core/generic.py
Comment on lines -6390 to -6402
@overload
def ffill(
self: FrameOrSeries,
axis: None | Axis = ...,
inplace: Literal[False] = ...,
limit: None | int = ...,
downcast=...,
) -> FrameOrSeries:
Copy link
Member Author

@MarcoGorelli MarcoGorelli May 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will put the overloads back in once the FutureWarning's in, then we won't need as many

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 24, 2021
@jreback jreback mentioned this pull request May 26, 2021
Closed
@jreback
Copy link
Contributor

jreback commented May 26, 2021

can you merge master

@jreback jreback merged commit eb7d46d into pandas-dev:master May 27, 2021
@MarcoGorelli MarcoGorelli deleted the deprecate-nonkeyword-args-ffill branch May 27, 2021 08:17
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@MarcoGorelli @TLouf
Deprecate passing args as positional DataFrame/Series.ffill (pandas-d…
7dc6b02 
…ev#41508)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@MarcoGorelli @JulianWgs
Deprecate passing args as positional DataFrame/Series.ffill (pandas-d…
075fcbd 
…ev#41508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @jreback @simonjayhawkins