DEPR: Series/DataFrame with tzaware data and tznaive dtype #41555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
May 18, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
@jbrockmendel can you resolve conflicts |
|
and add a release note. and a link to where this has been discussed. |
simonjayhawkins
added
Deprecate
|
whatsnew added + green |
jreback
requested changes
May 21, 2021
| value = maybe_unbox_datetimelike(value, dtype) | ||
| except TypeError: | ||
| if ( | ||
| isinstance(value, Timestamp) |
There was a problem hiding this comment.
does this apply to a datetime as well?
There was a problem hiding this comment.
good catch, will update, along with test
jreback
approved these changes
May 21, 2021
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
May 21, 2021
jreback
pushed a commit
that referenced
this pull request
May 22, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.