-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: ExcelWriter fails when passed kwargs #42292
Conversation
The open resource failures were from The fix for this is to break up the test for each engine, supplying valid kwargs (particularly, for xlsxwriter). Since this was already done in this PR, I've simply removed the invalid test. |
thanks @rhshadrach very nice. is there an issue to remove this for 1.4? |
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
For 2.0 - yes, it's part of #30228 |
Seeing some open resource test failure in excel writer, but not sure why. Checking if they occur on CI too.
Before this PR, I didn't notice that only xlsxwriter actually utilizes the kwargs/engine_kwargs. This makes the non-xlsxwriter tests slightly awkward - we pass the kwargs and just make sure the call to ExcelWriter doesn't fail because I don't see anything else to check.