Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF/REGR: restore IntervalIndex._intersection_non_unique #42334

Merged
merged 2 commits into from
Jul 1, 2021
Merged

PERF/REGR: restore IntervalIndex._intersection_non_unique #42334

merged 2 commits into from
Jul 1, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 1, 2021 •
edited by simonjayhawkins
Loading

Reverts the rest of #41929

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jul 1, 2021
@simonjayhawkins
Copy link
Member

i've milestoned 1.3 and hopefully the backport will be straightforward

@simonjayhawkins simonjayhawkins added Index Related to the Index class or subclasses Interval Interval data type Performance Memory or execution speed performance setops union, intersection, difference, symmetric_difference labels Jul 1, 2021
@simonjayhawkins
Copy link
Member

@jbrockmendel have you ran the asvs for this change?

@jbrockmendel
Copy link
Member Author

no i havent

@simonjayhawkins
Copy link
Member

ok. i'm winding down for the day.

this targets index_object.IntervalIndexMethod.time_intersection_both_duplicate(1000)?

should the asv be run before merging to check or confident this fixes?

@jbrockmendel
Copy link
Member Author

should the asv be run before merging to check or confident this fixes?

im moderately confident, but my intuition on this doesn't have a great track record over the last few days

@jreback
Copy link
Contributor

jreback commented Jul 1, 2021

let's merge and just do the rleease tomorrow. this is the point of point releases, we can always fix things.

@jreback jreback merged commit 5b9ca44 into pandas-dev:master Jul 1, 2021
@jreback
Copy link
Contributor

jreback commented Jul 1, 2021

@meeseeksdev backport 1.3.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jul 1, 2021
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#42334: PERF/REGR: restore IntervalIndex._inter…
c47b817 
…section_non_unique
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 1, 2021
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 1, 2021

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Jul 1, 2021
@meeseeksmachine @jbrockmendel
Backport PR #42334: PERF/REGR: restore IntervalIndex._intersection_no…
033041d 
…n_unique (#42336)

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@simonjayhawkins
Copy link
Member

im moderately confident, but my intuition on this doesn't have a great track record over the last few days

looking good... https://simonjayhawkins.github.io/fantastic-dollop/#index_object.IntervalIndexMethod.time_intersection_both_duplicate?branch=1.3.x&branch=1.2.x&commits=5940c9cf&p-param1=1000

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
PERF/REGR: restore IntervalIndex._intersection_non_unique (pandas-dev…
166e673 
…#42334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Interval Interval data type Performance Memory or execution speed performance setops union, intersection, difference, symmetric_difference
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @simonjayhawkins @jreback