Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC fix the incorrect doc style in 1.2.1 #42386

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

debnathshoham
Copy link
Member

@lithomas1 lithomas1 added the Docs label Jul 5, 2021
@jreback
Copy link
Contributor

jreback commented Jul 6, 2021

hmm, this looks fine, IIRC did we somehow change the whatsnew way back when?

cc @simonjayhawkins @datapythonista

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we used to use the ipython directive (the one automatically running the code, not the ipython format) in the whatsnew. But code was failing often as pandas evolves, since it is run with the latest pandas, and not the pandas version of the whatsnew. So, it was changed to not runnable examples. Based on the issue description, looks like we had to change them to the non-runnable ipython format, and we changed it to the standard python format.

This seems fine. Not sure I understand the resetting of the numbering (the 1 in In [1]...), I think it used to just increment for a whole file. But this seems fine to me, and more maintainable. Thanks for the work on this @debnathshoham

@jreback jreback modified the milestones: 1.4, 1.3.1 Jul 8, 2021
@jreback jreback merged commit 4653b6a into pandas-dev:master Jul 8, 2021
@jreback
Copy link
Contributor

jreback commented Jul 8, 2021

thanks @debnathshoham

@jreback
Copy link
Contributor

jreback commented Jul 8, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 8, 2021

Something went wrong ... Please have a look at my logs.

simonjayhawkins pushed a commit that referenced this pull request Jul 8, 2021
Co-authored-by: Shoham Debnath <debnathshoham@gmail.com>
@debnathshoham debnathshoham deleted the incorrect-doc-style branch July 9, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: fix the incorrect doc style in 1.2.1
4 participants