BUG: Series(dask.array) GH#38645 #42577
Conversation
|
do we want to include in 1.3.1? and include a release note so that users know that constructors now support the numpy array protocol? |
maybe also update the docs, although the discussion on what is array-like is ongoing #41807 |
simonjayhawkins
added
Constructors
|
Thanks! I can confirm that this works when paired with dask/dask#7905 which implements a lazy version of |
| @@ -560,8 +560,11 @@ def sanitize_array( | |||
| raise TypeError(f"'{type(data).__name__}' type is unordered") | |||
|
|
|||
| # materialize e.g. generators, convert e.g. tuples, abc.ValueView | |||
| # TODO: non-standard array-likes we can convert to ndarray more efficiently? | |||
| data = list(data) | |||
| if hasattr(data, "__array__"): | |||
There was a problem hiding this comment.
can you run this thru L518? where it makes more sense
There was a problem hiding this comment.
will take some rearrangement (move EA check about ndarray check) but i think doable
|
i suppose this is fine for 1.3.1 and can rearrange in a follow on if u can add a release note |
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
This should close #38645 in conjunction with dask/dask#7888, will hold off on closing the issue until @jsignell confirms.