REF: implement make_na_array #43606
Merged
REF: implement make_na_array #43606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 16, 2021
| @@ -449,6 +414,40 @@ def get_reindexed_values(self, empty_dtype: DtypeObj, upcasted_na) -> ArrayLike: | |||
| return values | |||
|
|
|||
|
|
|||
| def make_na_array(dtype: DtypeObj, shape: Shape) -> ArrayLike: | |||
There was a problem hiding this comment.
cool, FYI https://github.com/pandas-dev/pandas/blob/master/pandas/core/dtypes/cast.py#L1850 are somewhat similar in function (though not na)
jreback
added
Internals
3 tasks
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jun 15, 2022
This reverts commit 4bb4b52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be able to re-use make_na_array for AM and possibly BM._make_na_block