Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate positional arguments for read_fwf #44710

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Deprecate positional arguments for read_fwf #44710

merged 3 commits into from
Dec 2, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 1, 2021

Similar to read_csv this will simplify typing the return values

@phofl phofl added Deprecate Functionality to remove in pandas IO Fixed Width read_fwf labels Dec 1, 2021
MarcoGorelli
MarcoGorelli requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In similar PRs we were adding testing to check that the warning message would be raised - does that need adding here too, or is there enough confidence that it works as intended now?

@phofl
Copy link
Member Author

phofl commented Dec 1, 2021

Added a test.

MarcoGorelli
MarcoGorelli approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jreback jreback added this to the 1.4 milestone Dec 2, 2021
@jreback jreback mentioned this pull request Dec 2, 2021
Closed
@jreback jreback merged commit 08c688d into pandas-dev:master Dec 2, 2021
@phofl phofl deleted the dep_read_fwf_keyword_only branch December 10, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas IO Fixed Width read_fwf
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @MarcoGorelli @jreback