-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: avoid unnecessary ga mgmt calls if given profile_id upfront #4529
Conversation
|
|
I think basic docs in what's in their now are needed more functionality as useful |
Am I reading this correctly (first time using this)... that the test was not skipped since they aren't listed:
|
I dont' think this library is setup correctly for testing/missing deps
seems deps are similar to BigQuery: #4140; this has not been merged yet, but need to add them for |
minor correction full deps builds are 2.7, 3.2, and 3.3 |
this looks good...can you squash down to a single commit? otherwise ready 2 go? |
I think it's ready to go... I squashed the commit. |
there are still some issues with this. It is not clear if travis is even testting this; at the very least it should show that its skipping the tests (which its not), as I KNOW that it doesn't have the deps installed. There seem to be many more deps that we don't have installed, just from a quick try:
in the e.g.
then can see if its skipping and why doesn't google-api install all of these deps when it is installed? if not do you know why not? |
Installing I'm going to push the detailed exception change now and see what travis says. |
@tshauck can you update I am still not clear if this is actually testing properly |
please update |
uh, well if it exists :P |
@tshauck fyi...I added a Google Analytics label for issues.. |
@tshauck can you rebase and squash? |
@jreback I squashed it down to the original commit... |
why are the imports different among the 3 requirements files? what is glags? I still don't see it running any tests (or skipping) |
@tshauck pls rebase this on master. BigQuery was merged which used google-api (so you can take out from print_versions). install.rst may need updating as well. Also, pls put message on the SkipTests that skip because of missing deps or invalid authentication. Thanks |
After this is rebased, might want to ask one of the GBQ authors to test and |
@tshauck can you rebase? |
@jreback Will do when I have time. |
@tshauck gr8 thanks! |
@tshauck hmm...this got closed and can't reopen for some reason. |
It's because the branch was deleted... |
nah was changing versions and some issues for accident closed |
@tshauck progress on this? need to make sure that the ga calls are skipping appropriately if deps are not installed if you can validate those...and assuming you can test this locally we can get it in |
realted to #3507 |
gr8 important that the tests skip properly of the deps are not installed lmk |
@tshauck how's this coming? |
@tshauck ? |
closing this. pls resubmit when ready. |
profile_id
is ultimately what's needed to make a call to the reporting api. If it is specified in the parameter list it seems wasteful to call the management api 3 times.