Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 561 #45430

Closed
wants to merge 1 commit into from
Closed

PEP 561 #45430

wants to merge 1 commit into from

Conversation

QuentinN42
Copy link
Contributor

@QuentinN42 QuentinN42 commented Jan 17, 2022

According to PEP 561, we just need to add this file to mark the lib as typed.

I don't know if all the lib is typed, maybe we also need to do that before merging.

  • tests passed
  • Ensure all linting tests pass, see here for how to run them

@mroeschke
Copy link
Member

Thanks for the PR but this approach is still being discussed in #28142 and #45253, and pandas is not fully typed yet, so those issues need addressing before we can move forward with this.

Closing, but feel free to engage in the discussion in those issues first to move this along!

@mroeschke mroeschke closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants