ENH: Add numeric_only to certain groupby ops #46728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Enhancement
Groupby
Nuisance Columns
14 tasks
rhshadrach
changed the title
4 tasks
…numeric_only_gb � Conflicts: � pandas/core/frame.py � pandas/core/groupby/generic.py � pandas/core/shared_docs.py
rhshadrach
changed the title
…numeric_only_gb
…andas into add_numeric_only_gb
mroeschke
reviewed
Apr 16, 2022
mroeschke
approved these changes
Apr 16, 2022
…numeric_only_gb � Conflicts: � doc/source/whatsnew/v1.5.0.rst
rhshadrach
force-pushed
the
add_numeric_only_gb
branch
from
5620a69
to
8e435ab
Compare
…numeric_only_gb
|
@jreback - gentle ping. |
jreback
requested changes
Apr 23, 2022
pandas/core/groupby/groupby.py
Outdated
| else: | ||
| nonnumeric_exclusions = frozenset() | ||
| with com.temp_setattr( | ||
| self, "exclusions", self.exclusions | nonnumeric_exclusions |
There was a problem hiding this comment.
Thanks - I was able to remove this hack by setting the appropriate value of raise_on_typeerror.
…numeric_only_gb
…numeric_only_gb � Conflicts: � doc/source/whatsnew/v1.5.0.rst
jreback
approved these changes
Apr 30, 2022
|
thanks @rhshadrach very nice! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46560
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.For the ops that have numeric_only added, we have the option of dropping nuisance columns even when
numeric_only=Falseis specified to be consistent with other groupby ops (e.g. sum). I decided to implement the correct behavior here instead; this required adding an argument to the cython/python paths. This argument can be removed in 2.0 when all ops would raise.