DEPR: groupby numeric_only default #47025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
Deprecate
jreback
requested changes
May 15, 2022
pandas/core/groupby/groupby.py
Outdated
| libgroupby.group_var, | ||
| cython_dtype=np.dtype(np.float64), | ||
| numeric_only=numeric_only, | ||
| needs_counts=True, | ||
| post_processing=lambda vals, inference: np.sqrt(vals), | ||
| ddof=ddof, | ||
| ) | ||
| if ( | ||
| self.axis != 1 |
There was a problem hiding this comment.
can you make a helper for this rather than repeating?
| @@ -81,6 +81,7 @@ def get_stats(group): | |||
| assert result.index.names[0] == "C" | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings("ignore:.*value of numeric_only.*:FutureWarning") | |||
There was a problem hiding this comment.
can you explictily test these rather than filtering (alt pass numeric_only=False) as needed
|
Thanks @jreback; filterwarnings has been removed and the helper had been added. |
jreback
approved these changes
May 18, 2022
|
very nice @rhshadrach |
|
I think this causes the doc build to fail with multiple of these warnings:
Would probably need to update the documentation to avoid these FutureWarnings. |
|
Thanks @twoertwein - will do a follow up. |
4 tasks
mroeschke
added a commit
that referenced
this pull request
May 25, 2022
* TYP: NoDefault * ix mypy issues; re-write isinstance(..., NoDefault) * remove two more casts * ENH: DatetimeArray fields support non-nano (#47044) * DEPR: groupby numeric_only default (#47025) * DOC: Clarify decay argument validation in ewm when times is provided (#47026) * DOC: Fix some typos in pandas/. (#47022) * remove two more casts * avoid cast-like annotation * left/right * cannot use | Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com> Co-authored-by: Matthew Roeschke <emailformattr@gmail.com> Co-authored-by: Shuangchi He <34329208+Yulv-git@users.noreply.github.com>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: NoDefault * ix mypy issues; re-write isinstance(..., NoDefault) * remove two more casts * ENH: DatetimeArray fields support non-nano (pandas-dev#47044) * DEPR: groupby numeric_only default (pandas-dev#47025) * DOC: Clarify decay argument validation in ewm when times is provided (pandas-dev#47026) * DOC: Fix some typos in pandas/. (pandas-dev#47022) * remove two more casts * avoid cast-like annotation * left/right * cannot use | Co-authored-by: jbrockmendel <jbrockmendel@gmail.com> Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com> Co-authored-by: Matthew Roeschke <emailformattr@gmail.com> Co-authored-by: Shuangchi He <34329208+Yulv-git@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.There are two cases we want to emit a deprecation warning for DataFrameGroupBy: