Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Start Testing on Python 3.11 #47032

Closed
wants to merge 15 commits into from

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented May 15, 2022

It's that time of the year again.

Surprisingly, there are not a lot of failures this year.

@EwoutH
Copy link
Contributor

EwoutH commented May 18, 2022

Thanks for the effort!

Cython 0.29.29 and 0.29.30 were released and NumPy bumped their Cython requirement on the main branch, so I think if you rebase this (and thereby trigger the CI again), it will come a bit further.

@lithomas1
Copy link
Member Author

I think we already picked up 0.29.29 here(it compiles fine). I can try again with 0.29.30, but sadly these test failures look real.

@jreback jreback added the CI Continuous Integration label May 18, 2022
_get_overlap_public_nat_methods(Timestamp, True)
+ _get_overlap_public_nat_methods(Timedelta, True)
Timestamp,
Timedelta
),
Copy link
Contributor

@EwoutH EwoutH May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you combine those four lines to a single line with (Timestamp, Timedelta),, it conforms to black formatting and the linting error will go away (see the CI run).

-    (
-        Timestamp,
-        Timedelta
-    ),
+    (Timestamp, Timedelta),

@EwoutH
Copy link
Contributor

EwoutH commented May 30, 2022

@lithomas1 Any progress on this effort? Should we open issues for the test failures?

@lithomas1
Copy link
Member Author

@EwoutH No, they are mainly because an error message changed, and so should be relatively easy to fix. Does anyone downstream need this(can prioritize this if so)?

I'm a bit short on time right now, so I'll be squeezing in commits here and there, but it might take me a while to fix up all the tests.

You might also want to hold off reviewing right now, as there are going to be a lot of WIP commits, and I don't want to waste your time reviewing. I can ping you when this is ready.

@lithomas1
Copy link
Member Author

@github-actions pre-commit

@pandas-dev pandas-dev deleted a comment from pep8speaks May 30, 2022
@lithomas1
Copy link
Member Author

@github-actions pre-commit

@pandas-dev pandas-dev deleted a comment from pep8speaks May 30, 2022
@mroeschke mroeschke mentioned this pull request Jun 21, 2022
5 tasks
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 23, 2022
@EwoutH
Copy link
Contributor

EwoutH commented Jul 30, 2022

@lithomas1 Thanks for the effort so far. Are you still working on this?

@lithomas1
Copy link
Member Author

This PR is currently superseded by #47442. That PR is still blocked by #47467. I expect to finish up #47467 and get it merged within the next week.

@lithomas1 lithomas1 closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Python 3.11 Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants