-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Start Testing on Python 3.11 #47032
Conversation
I think we already picked up 0.29.29 here(it compiles fine). I can try again with 0.29.30, but sadly these test failures look real. |
pandas/tests/scalar/test_nat.py
Outdated
_get_overlap_public_nat_methods(Timestamp, True) | ||
+ _get_overlap_public_nat_methods(Timedelta, True) | ||
Timestamp, | ||
Timedelta | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you combine those four lines to a single line with (Timestamp, Timedelta),
, it conforms to black formatting and the linting error will go away (see the CI run).
- (
- Timestamp,
- Timedelta
- ),
+ (Timestamp, Timedelta),
@lithomas1 Any progress on this effort? Should we open issues for the test failures? |
@EwoutH No, they are mainly because an error message changed, and so should be relatively easy to fix. Does anyone downstream need this(can prioritize this if so)? I'm a bit short on time right now, so I'll be squeezing in commits here and there, but it might take me a while to fix up all the tests. You might also want to hold off reviewing right now, as there are going to be a lot of WIP commits, and I don't want to waste your time reviewing. I can ping you when this is ready. |
@github-actions pre-commit |
@github-actions pre-commit |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
@lithomas1 Thanks for the effort so far. Are you still working on this? |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.It's that time of the year again.
Surprisingly, there are not a lot of failures this year.