Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: move enhancements in 1.5 release notes #47375

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

simonjayhawkins
Copy link
Member

@ParfaitG can you confirm these are enhancements and not api breaking changes.

@ParfaitG
Copy link
Contributor

Confirmed. These are extended, new features of pandas.read_xml (new IO module introduced in 1.3).

@simonjayhawkins simonjayhawkins added this to the 1.5 milestone Jun 15, 2022
@simonjayhawkins simonjayhawkins marked this pull request as ready for review June 15, 2022 21:03
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just one question, but feel free to merge when you're ready


.. _`lxml's iterparse`: https://lxml.de/3.2/parsing.html#iterparse-and-iterwalk
.. _`etree's iterparse`: https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.iterparse
api_breaking_change1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these just placeholders? Do we need to keep them now that the section has content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in keeping for now. Hopefully no significant breaking changes in the 1.5 release other than the ones that are considered bug fixes (in a different section). We may need to add something for #47365 (if we don't revert to 1.4.2 behavior) that is more detailed than would fit in the one-liner section.

@mroeschke mroeschke merged commit 8c0dbaa into pandas-dev:main Jun 23, 2022
@simonjayhawkins simonjayhawkins deleted the move-enhancements branch June 24, 2022 09:39
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* DOC: move enhancements in 1.5 release notes

* remove rogue hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants