Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate non-keyword arguments for rsplit #47446

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Deprecate non-keyword arguments for rsplit #47446

merged 7 commits into from
Jun 23, 2022

Conversation

MrShevan
Copy link
Contributor

@MarcoGorelli MarcoGorelli self-requested a review June 21, 2022 18:09
@MrShevan MrShevan marked this pull request as ready for review June 21, 2022 18:51
@datapythonista datapythonista added Strings String extension data type and string data Deprecate Functionality to remove in pandas labels Jun 22, 2022
datapythonista
datapythonista approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MrShevan, looks good to me. The CI failures seem unrelated.

MarcoGorelli
MarcoGorelli approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, impressive to a first PR ready to go - do you want to do the same for split? (Either here or in a separate PR would be fine)

Looks good to me pending (probably unrelated) CI failures

@MrShevan
Copy link
Contributor Author

MrShevan commented Jun 22, 2022 •
edited
Loading

@MarcoGorelli @datapythonista Thanks for reviewing! Year, sure, I'll do the same for split method today in this PR. Fails look unrelated to PR, I hope it disappears after updating branch with new master :)

@jreback jreback added this to the 1.5 milestone Jun 22, 2022
@jreback jreback mentioned this pull request Jun 22, 2022
Closed
@jreback
Copy link
Contributor

jreback commented Jun 22, 2022

https://github.com/pandas-dev/pandas/runs/7007844136?check_suite_focus=true

hmm these are all unrelated i supposed

cc @mroeschke

mroeschke
mroeschke approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the failures look unrelated. Thanks!

@mroeschke mroeschke merged commit 771f2b1 into pandas-dev:main Jun 23, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@MrShevan @yehoshuadimarsky
Deprecate non-keyword arguments for rsplit (pandas-dev#47446)
3d9027b 
* Deprecate non-keyword arguments for rsplit

* linter fix

* Deprecate non-keyword arguments for split

Co-authored-by: Anton Shevtsov <aeshevtsov@avito.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@mroeschke mroeschke mroeschke approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Strings String extension data type and string data
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Unexpected keyword argument maxsplit on rsplit even though it is accepted in vanilla Python
5 participants
@MrShevan @jreback @datapythonista @mroeschke @MarcoGorelli