-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPS/TST: tzdata is optional, not required #47467
Merged
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2939c10
DEPS/TST: tzdata is optional, not required
lithomas1 d4642a9
Fix name & formatting
lithomas1 9a75b85
another one
lithomas1 e112474
Merge branch 'main' into fix-tzdata-checking
lithomas1 371e7fb
Merge branch 'pandas-dev:main' into fix-tzdata-checking
lithomas1 bfff268
Update pandas/conftest.py
lithomas1 3c94243
make tzdata an optional dependency
lithomas1 7e48282
Merge branch 'fix-tzdata-checking' of github-other.com:lithomas1/pand…
lithomas1 eba2fb9
update
lithomas1 6d7c577
Merge branch 'main' into fix-tzdata-checking
lithomas1 19df15c
fix env files
lithomas1 19438d2
Merge branch 'fix-tzdata-checking' of github-other.com:lithomas1/pand…
lithomas1 f36bbe6
fix typing
lithomas1 5917870
Merge branch 'main' into fix-tzdata-checking
lithomas1 093ca1d
fix formatting
lithomas1 64de406
Update tzdata note
lithomas1 9a973f0
code checks
lithomas1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022a | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022a | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ dependencies: | |
- scipy | ||
- sqlalchemy | ||
- tabulate | ||
- tzdata>=2022a | ||
- xarray | ||
- xlrd | ||
- xlsxwriter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,7 @@ s3fs | |
scipy | ||
sqlalchemy | ||
tabulate | ||
tzdata>=2022.1 | ||
xarray | ||
xlrd | ||
xlsxwriter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the
2022a
is a conda forge package?https://anaconda.org/conda-forge/tzdata
https://github.com/eggert/tz
Which is a different project from tzdata (
2022.1
).https://pypi.org/project/tzdata/#history
https://github.com/python/tzdata
I'm not sure it's a good idea to recommend 2 differently maintained packages here. Can we just recommend the pypi one since it's the once recommended in the official docs https://docs.python.org/3/library/zoneinfo.html#data-sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd still want to state a min version for system tzdata for consistency. 2022a is also the version of the actual IANA tz db(it's python's tzdata versioning scheme that's different).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay sounds reasonable then. Might be good then to mention that the system tzdata can be updated by installing the conda forge package?