-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ArrowDype and .array.ArrowExtensionArray to top level #47818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally not fully convinced that we should already expose this publicly at the top-level, without first discussing how we think to integrate this longer term (or at least not without very explicitly marking this as an experimental feature that we don't necessarily intend to keep this way long term, while already allowing people to try it out and give feedback).
For example, I am -1 on deprecating the StringDtype(storage="arrow")
. This model allows it to be more an implementation detail (where most users don't need to be aware whether their pandas columns / dtypes are backed by numpy or arrow). (although it is already not fully the case, as a string[python] dtype isn't equal to a string[pyarrow]
|
#47854 would be a start to the documentation of the functionality I was hoping to demonstrate |
I'm fine with adding these to the top level (reasoning: just having support for storage of these types in a DataFrame is helpful, even if many operations fail). Agreed with Joris that we shouldn't deprecate |
Okay agreed. Considering deprecation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. i agree exposing these at the top level is tantamount to what we do with other types.
@jorisvandenbossche as discussed in the dev meeting today, documentation noting that this is experimental was made in 4e3b3b9 in #47854 |
Will probably merge this PR this week if no further comments. |
Going to merge. Can address any followups if needed in #47854 |
…s-dev#47818) * ENH: Add ArrowDype and .array.ArrowExtensionDtype to top level * ensure string[pyarrow] dispatches to StringDtype for now * type ignores * Address availability of Pyarrow * Address typing
…s-dev#47818) * ENH: Add ArrowDype and .array.ArrowExtensionDtype to top level * ensure string[pyarrow] dispatches to StringDtype for now * type ignores * Address availability of Pyarrow * Address typing
Moved
ArrowIntervalType
andArrowPeriodType
to a separate filearrow/extension_types.py
to avoid a circular import.Will add documentation in a separate PR #47854