Added improvements in to_datetime Error reporting message - incorrect field today/now shown in error #47860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyi96
force-pushed
the
today_now_error
branch
from
485615c
to
0c70cee
Compare
1 task
|
hi @mroeschke, could you please review this change whenever possible ? |
mroeschke
reviewed
Aug 8, 2022
mroeschke
added
Datetime
mroeschke
reviewed
Aug 12, 2022
mroeschke
reviewed
Aug 12, 2022
mroeschke
approved these changes
Aug 15, 2022
|
Thanks @dannyi96 |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
… field today/now shown in error (pandas-dev#47860) * Revert "addressing reviews CL#1" This reverts commit 69dc2d4. * Added improvements in to_datetime Error reporting message - incorrect field now/today shown as error * Added improvements in to_datetime Error reporting message - incorrect field now/today shown as error * added testcase * adding position info & updated testcase * precommit format changes * addressing review comments * addressing review comments * addressing review comments * addressing review comments * addressing review comments pandas-dev#2 * addressing review comments
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
… field today/now shown in error (pandas-dev#47860) * Revert "addressing reviews CL#1" This reverts commit 69dc2d4. * Added improvements in to_datetime Error reporting message - incorrect field now/today shown as error * Added improvements in to_datetime Error reporting message - incorrect field now/today shown as error * added testcase * adding position info & updated testcase * precommit format changes * addressing review comments * addressing review comments * addressing review comments * addressing review comments * addressing review comments #2 * addressing review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting changes from #47597, This PR aims to close the bug #47495
Changes description
pandas/_libs/tslib.pyxto accept "now" and "today" values. These values are accepted in other areas of parsing (_parse_today_nowinpandas/_libs/tslib.pyx)Example of changed error messages