REGR: setting numeric value in Categorical Series with enlargement raise internal error #48106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Indexing
mroeschke
reviewed
Aug 16, 2022
mroeschke
reviewed
Aug 16, 2022
phofl
changed the title
mroeschke
approved these changes
Aug 16, 2022
|
Will do |
Closed
5 tasks
Closed
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…ise internal error (pandas-dev#48106) * fix regression when loc is used to create a new element on an categorical series * add whatsnew * fix enlarging by scalar * update due to PR discussions * remove unnecessary comment * WIP: fix nan for enlarging * add tests; fix nan in _maybe_promote * remove unnecessary statement * use any_numeric_ea_dtype for tests * Refactor * Add line back in * Add NaT * Remove whatsnew Co-authored-by: tobias.pitters <tobias.pitters@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Somehow I can not push to the branch of #47751
@CloseChoice Feel free to continue on your branch, if you are available. Otherwise we can merge this one.