Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGR: setting numeric value in Categorical Series with enlargement raise internal error #48106

Merged
merged 17 commits into from
Aug 16, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 16, 2022

Somehow I can not push to the branch of #47751

@CloseChoice Feel free to continue on your branch, if you are available. Otherwise we can merge this one.

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Categorical Categorical Data Type labels Aug 16, 2022
@phofl phofl added this to the 1.5 milestone Aug 16, 2022
@phofl phofl changed the title FIX: REGR: setting numeric value in Categorical Series with enlargement raise internal error REGR: setting numeric value in Categorical Series with enlargement raise internal error Aug 16, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy to have you merge this version on green.

@phofl
Copy link
Member Author

phofl commented Aug 16, 2022

Will do

@phofl phofl merged commit aa9a1b3 into pandas-dev:main Aug 16, 2022
@phofl phofl deleted the 2022-07-16-REGR-47677 branch August 16, 2022 21:23
@mroeschke mroeschke mentioned this pull request Aug 16, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…ise internal error (pandas-dev#48106)

* fix regression when loc is used to create a new element on an categorical series

* add whatsnew

* fix enlarging by scalar

* update due to PR discussions

* remove unnecessary comment

* WIP: fix nan for enlarging

* add tests; fix nan in _maybe_promote

* remove unnecessary statement

* use any_numeric_ea_dtype for tests

* Refactor

* Add line back in

* Add NaT

* Remove whatsnew

Co-authored-by: tobias.pitters <tobias.pitters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: setting numeric value in Categorical Series with enlargement raise internal error
3 participants