Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Explicitly state pip as a dependency in environment.yml #48148

Merged
merged 6 commits into from
Aug 24, 2022
Merged

BLD: Explicitly state pip as a dependency in environment.yml #48148

merged 6 commits into from
Aug 24, 2022

Conversation

ambujpawar
Copy link
Contributor

@ambujpawar ambujpawar commented Aug 19, 2022 •
edited
Loading

@ambujpawar ambujpawar marked this pull request as draft August 19, 2022 09:06
@ambujpawar ambujpawar marked this pull request as ready for review August 21, 2022 15:49
@ambujpawar
Copy link
Contributor Author

Used this to solve it: conda/conda#10614

@mroeschke mroeschke added the Dependencies Required and optional dependencies label Aug 22, 2022
MarcoGorelli
MarcoGorelli requested changes Aug 22, 2022
View reviewed changes
environment.yml Outdated Show resolved Hide resolved
MarcoGorelli
MarcoGorelli approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me on green

@ambujpawar
Copy link
Contributor Author

ambujpawar commented Aug 22, 2022 •
edited
Loading

CI check seems to be continously failing over here. Probably #48180 might solve the issue
In the meantime is can the reviewers please rerun the failing job? Or shall I wait for the #48180 to be merged to master?

@MarcoGorelli
Copy link
Member

no need, someone can update the branch once the circleci issue is resolved

@ambujpawar
Copy link
Contributor Author

Ah understood! Thanks for the fast reply :)

@ambujpawar
Copy link
Contributor Author

ambujpawar commented Aug 23, 2022 •
edited
Loading

looks good to me on green

68747470733a2f2f692e666c756666792e63632f425067785a6b6d7372676d6663444644434e5743336d3443573067434a4637772e676966

@MarcoGorelli all the tests are passing now. Shall we merge it to the main now? Or shall I add something else to this PR?

@MarcoGorelli MarcoGorelli added this to the 1.6 milestone Aug 24, 2022
@MarcoGorelli MarcoGorelli merged commit 2e96193 into pandas-dev:main Aug 24, 2022
@ambujpawar ambujpawar deleted the 48036_add_pip_to_environment branch August 26, 2022 05:37
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@ambujpawar @noatamir
BLD: Explicitly state pip as a dependency in environment.yml (pandas-…
ab40c0d 
…dev#48148)

* BLD: Explicitly state pip as a dependency in environment.yml

* BLD: Changes in environment.yml should be represented in requirements.txt as well

* BLD: Add defaults channel to environment.yml for explicit pip dependency

* default channel not needed. Removing it

* move pip dependency to top of environment.yaml

Co-authored-by: Ambuj Pawar <ambuj.pawar95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

DEP: Add pip to environment.yml
3 participants
@ambujpawar @MarcoGorelli @mroeschke