BUG: DataFrame.pivot not respecting None as column name #48293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+1 for this. |
|
Will open a pr to backport to 1.5rc then, will convert this to draft till the other pr is merged then to simplify the backport |
# Conflicts: # pandas/core/frame.py
|
cc @mroeschke I think this is ready for another look now |
mroeschke
reviewed
Sep 9, 2022
# Conflicts: # doc/source/whatsnew/v1.6.0.rst
mroeschke
reviewed
Sep 9, 2022
mroeschke
reviewed
Sep 9, 2022
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
mroeschke
approved these changes
Sep 12, 2022
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…8293) * BUG: DataFrame.pivot not respecting None as column name * Add gh ref * Fix test * Add comment * Update doc/source/whatsnew/v1.6.0.rst Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Columns can never be empty when called by the user, should we deprecate positional arguments here and then remove the default? avoids the check on our side and simplifies things a bit