Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Clean circleci setup env file #48315

Merged
merged 1 commit into from
Aug 31, 2022
Merged

CI: Clean circleci setup env file #48315

merged 1 commit into from
Aug 31, 2022

Conversation

mroeschke
Copy link
Member

#48307 is tracked by #47305. Cleaning the setup_ev.sh file since it's only used for this build.

@mroeschke mroeschke added the CI Continuous Integration label Aug 30, 2022
@phofl
Copy link
Member

phofl commented Aug 30, 2022

Thx for this. Wasn’t aware that the issue was still open.

should we switch to mambaforge as a follow up?

@mroeschke mroeschke added this to the 1.6 milestone Aug 30, 2022
@mroeschke
Copy link
Member Author

should we switch to mambaforge as a follow up?

Yes, that would be a useful followup PR.

phofl
phofl approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Should investigate in the future to check if we can get this running again in parallel. This is quite a performance penalty.

@phofl phofl merged commit b3e8bbe into pandas-dev:main Aug 31, 2022
@phofl
Copy link
Member

phofl commented Aug 31, 2022

Thx @mroeschke

@mroeschke mroeschke deleted the ci/circle_clean branch August 31, 2022 19:12
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
CI: Clean circleci setup env file (pandas-dev#48315)
d6ea2e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

CI: compile fails sometimes on ci because of undefined object
2 participants
@mroeschke @phofl