TST: Filter false positive matplotlib warning #48317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
|
thx @mroeschke |
jbrockmendel
reviewed
Nov 4, 2022
| with warnings.catch_warnings(): | ||
| # https://github.com/matplotlib/matplotlib/issues/23614 | ||
| # False positive deprecation warning until matplotlib=3.6 | ||
| warnings.filterwarnings("ignore", "Auto-removal of grids") |
There was a problem hiding this comment.
is this unnecessary now that our min version is 3.6.1?
There was a problem hiding this comment.
Yeah I think based on matplotlib/matplotlib#23614 (comment) should be safe to remove
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref matplotlib/matplotlib#23614.
This false positive warning showed up in our test suite and can be filtered out.