-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: AttributeError: 'function' object has no attribute 'currentframe' #48736
Merged
mroeschke
merged 6 commits into
pandas-dev:main
from
MarcoGorelli:case-insensitive-table-name
Sep 26, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b4e97f7
sqlalchemy.inspect shouldnt shadow builtin inspect
c59c8c2
:label:
8d8da1d
reword in terms of to_sql
cf671ec
Merge remote-tracking branch 'upstream/main' into case-insensitive-ta…
df5024c
Merge remote-tracking branch 'upstream/main' into case-insensitive-ta…
b780065
import sqlalchemy.inspect as sqlalchemy_inspect
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche since there is
check_case_sensitive
, I think it is possible to test the warning without altering the database?This text was added in https://github.com/pandas-dev/pandas/pull/8180/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's from a long time ago ;)
Yes, we can certainly test the helper method to raise the warning (as you did now), that's useful to add, but strictly speaking that's still not a 100% guarantee that it will work in practice, as it doesn't ensure we call this helper method (we could accidentally remove that in a refactor).
(maybe we could also mock the helper to ensure it's being called from to_sql .. but I think the current test is also good enough)