Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Enforce ewm(times=str) deprecation #48842

Merged
merged 13 commits into from
Oct 21, 2022

Conversation

mroeschke
Copy link
Member

Introduced in #43265

@mroeschke mroeschke added Deprecate Functionality to remove in pandas Window rolling, ewma, expanding labels Sep 29, 2022
@mroeschke mroeschke added this to the 2.0 milestone Sep 29, 2022
@jbrockmendel
Copy link
Member

Test that it raises? Whatsnew?

@mroeschke mroeschke marked this pull request as ready for review October 19, 2022 23:57
@mroeschke
Copy link
Member Author

Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing needs fixing, otherwise lgtm

@mroeschke mroeschke merged commit 84593e3 into pandas-dev:main Oct 21, 2022
@mroeschke mroeschke deleted the depr/rm/ewm_times_str branch October 21, 2022 18:30
phofl pushed a commit to phofl/pandas that referenced this pull request Oct 21, 2022
* DEPR: Enforce ewm(times=str) deprecation

* Fix typing

* Fix test

* convert test to raises

* Add whatsnew

* Fix typing

* fix typing
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* DEPR: Enforce ewm(times=str) deprecation

* Fix typing

* Fix test

* convert test to raises

* Add whatsnew

* Fix typing

* fix typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants