-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: Enforce ewm(times=str) deprecation #48842
Conversation
Test that it raises? Whatsnew? |
Added test here https://github.com/pandas-dev/pandas/pull/48842/files#diff-3f0452bb29c5fda1dfc3fb1ec8346ac3a1fffe504c857d232c1df7a043b45ad8R239 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typing needs fixing, otherwise lgtm
* DEPR: Enforce ewm(times=str) deprecation * Fix typing * Fix test * convert test to raises * Add whatsnew * Fix typing * fix typing
* DEPR: Enforce ewm(times=str) deprecation * Fix typing * Fix test * convert test to raises * Add whatsnew * Fix typing * fix typing
Introduced in #43265