Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Add code check to avoid returning Exceptions instead of raising #48948

Merged
merged 9 commits into from
Oct 7, 2022
Merged

STYLE: Add code check to avoid returning Exceptions instead of raising #48948

merged 9 commits into from
Oct 7, 2022

Conversation

mroeschke
Copy link
Member

Technically, code like return variable where variable is an exception won't be caught, but this is probably a first good step and an AST check would have the same issue with the node.id

Motivated by #48834 #48833

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 5, 2022
@mroeschke mroeschke added this to the 1.6 milestone Oct 6, 2022
@phofl phofl merged commit c0c6537 into pandas-dev:main Oct 7, 2022
@phofl
Copy link
Member

phofl commented Oct 7, 2022

thx @mroeschke

@mroeschke mroeschke deleted the check/exceptions_raise branch October 7, 2022 16:26
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
STYLE: Add code check to avoid returning Exceptions instead of raising (
3a47936 
pandas-dev#48948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

STYLE: Add code check to avoid returning Exceptions instead of raising
2 participants
@mroeschke @phofl