Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: Better warning in pivot_table when dropping nuisance columns #49615

Merged
merged 2 commits into from
Nov 10, 2022
Merged

REGR: Better warning in pivot_table when dropping nuisance columns #49615

merged 2 commits into from
Nov 10, 2022

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Warnings Warnings that appear or should be added to pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Nov 10, 2022
@rhshadrach rhshadrach added this to the 1.5.2 milestone Nov 10, 2022
mroeschke
mroeschke reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this warrant a whatsnew?

phofl
phofl approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, this looks great.

I don't think we need a whatsnew here

@rhshadrach
Copy link
Member Author

Agreed @phofl - users are currently getting FutureWarnings, so really no behavior change. The change in message is just a bit easier to understand.

@mroeschke mroeschke merged commit ab89c53 into pandas-dev:main Nov 10, 2022
@mroeschke
Copy link
Member

Thanks @rhshadrach

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 10, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@rhshadrach
Copy link
Member Author

@mroeschke - I can take care of the backport, but meeseeks usually has very explicit output for doing so - did this get moved to somewhere else?

@phofl
Copy link
Member

phofl commented Nov 10, 2022

its also not adding the manual backport label, something is off

@mroeschke
Copy link
Member

Don't think this should have changed. I'll try retriggering the backport

@mroeschke
Copy link
Member

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 10, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@rhshadrach
Copy link
Member Author

@meeseeksdev say hi

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 10, 2022

hi

@Sierra-MC
Copy link

Thank you!

@rhshadrach
Copy link
Member Author

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 11, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

rhshadrach added a commit to rhshadrach/pandas that referenced this pull request Nov 11, 2022
@rhshadrach
REGR: Better warning in pivot_table when dropping nuisance columns (p…
8d80e0b 
…andas-dev#49615)

* REGR: Better warning in pivot_table when dropping nuisance columns

* type-hint fixups

(cherry picked from commit ab89c53)
phofl pushed a commit that referenced this pull request Nov 11, 2022
@rhshadrach @ntachukwu
Backport PR #49615 on branch 1.5.x (REGR: Better warning in pivot_tab…
136271a 
…le when dropping nuisance columns) (#49653)

(cherry picked from commit ab89c53)

Co-authored-by: Dennis Chukwunta <chuksmcdennis@yahoo.com>
codamuse pushed a commit to codamuse/pandas that referenced this pull request Nov 12, 2022
@rhshadrach @codamuse
REGR: Better warning in pivot_table when dropping nuisance columns (p…
0533e09 
…andas-dev#49615)

* REGR: Better warning in pivot_table when dropping nuisance columns

* type-hint fixups
@rhshadrach rhshadrach deleted the pivot_table_nuisance_warning branch November 13, 2022 15:06
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@rhshadrach @mliu08
REGR: Better warning in pivot_table when dropping nuisance columns (p…
ddfd4d4 
…andas-dev#49615)

* REGR: Better warning in pivot_table when dropping nuisance columns

* type-hint fixups
@rhshadrach rhshadrach mentioned this pull request Dec 18, 2022
Closed
@MarcoGorelli
Copy link
Member

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 12, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ab89c53f48df67709a533b6a95ce3d911871a0a8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #49615: REGR: Better warning in pivot_table when dropping nuisance columns'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-49615-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #49615 on branch 1.5.x (REGR: Better warning in pivot_table when dropping nuisance columns)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Jan 12, 2023
@rhshadrach
Backport PR pandas-dev#49615: REGR: Better warning in pivot_table whe…
5796fe6 
…n dropping nuisance columns
@MarcoGorelli
Copy link
Member

looks like this was already backported manually in #49653

removing the 'still needs manual backport' then

@simonjayhawkins simonjayhawkins mentioned this pull request Jan 12, 2023
Merged
@rhshadrach
Copy link
Member Author

Ack - sorry for my bad bookkeeping @MarcoGorelli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reshaping Concat, Merge/Join, Stack/Unstack, Explode Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

BUG: Getting FutureWarning for Groupby.mean when using .pivot_table
5 participants
@rhshadrach @mroeschke @phofl @Sierra-MC @MarcoGorelli